public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1584 from egrs/fix-textarea-selection-insert

Browse Source 
fix textarea text insertion to respect selection range
This commit is contained in:
Pierre Tachoire
2026-02-20 15:24:39 +01:00
committed by GitHub
parent d38ded0f26 37ecd5cdef
commit eb55030b06
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/browser/Page.zig
View File

@@ -3131,9 +3131,7 @@ pub fn handleKeydown(self: *Page, target: *Node, event: *Event) !void {
else return else return
; ;
// zig fmt: on // zig fmt: on
const current_value = textarea.getValue(); return textarea.innerInsert(append, self);
const new_value = try std.mem.concat(self.arena, u8, &.{ current_value, append });
return textarea.setValue(new_value, self);
} }
} }
@@ -3218,13 +3216,11 @@ pub fn insertText(self: *Page, v: []const u8) !void {
return; return;
} }
try input.innerInsert(v, self); return input.innerInsert(v, self);
} }
if (html_element.is(Element.Html.TextArea)) |textarea| { if (html_element.is(Element.Html.TextArea)) |textarea| {
const current_value = textarea.getValue(); return textarea.innerInsert(v, self);
const new_value = try std.mem.concat(self.arena, u8, &.{ current_value, v });
return textarea.setValue(new_value, self);
} }
} }