public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Don't emit incorrect empty chunk

Browse Source 
When we only have 1 or 2 bytes missing from a chunk (i.e. the tailing \n or
\r\n), don't emit an empty chunk if we have more data available to process.
This commit is contained in:
Karl Seguin
2025-04-07 22:40:02 +08:00
parent 92e2daf056
commit ec9a1416a1
1 changed files with 29 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/http/client.zig
View File

@@ -1342,24 +1342,38 @@ const Reader = struct {
const size = self.size.?; const size = self.size.?;
const missing = self.missing; const missing = self.missing;
if (data.len >= missing) { if (data.len >= missing) {
// we have a complete chunk;
var chunk: ?[]u8 = data;
if (missing == 1) {
const last = missing - 1;
if (data[last] != '\n') {
return error.InvalidChunk;
}
chunk = null;
} else {
const last = missing - 2;
if (data[last] != '\r' or data[missing - 1] != '\n') {
return error.InvalidChunk;
}
chunk = if (last == 0) null else data[0..last];
}
self.size = null; self.size = null;
self.missing = 0; self.missing = 0;
if (missing == 1) {
if (data[0] != '\n') {
return error.InvalidChunk;
}
if (data.len == 1) {
return .{ true, .{ .data = null, .done = size == 0, .unprocessed = null } };
}
return self.process(data[1..]);
}
if (missing == 2) {
if (data[0] != '\r' or data[1] != '\n') {
return error.InvalidChunk;
}
if (data.len == 2) {
return .{ true, .{ .data = null, .done = size == 0, .unprocessed = null } };
}
return self.process(data[2..]);
}
// we have a complete chunk;
var chunk: ?[]u8 = data;
const last = missing - 2;
if (data[last] != '\r' or data[missing - 1] != '\n') {
return error.InvalidChunk;
}
chunk = if (last == 0) null else data[0..last];
const unprocessed = data[missing..]; const unprocessed = data[missing..];