public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 12:44:43 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Add dummy window.opener accessor

Browse Source 
This seems pretty complicated to implement...mostly because we'd have to keep
a window around in certain cases and because exactly what's accessible on that
window depends on a few factors.
This commit is contained in:
Karl Seguin
2026-02-07 17:51:58 +08:00
parent aca3fae6b1
commit ee22e07fff
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/browser/tests/window/window.html
View File

@@ -5,6 +5,7 @@
testing.expectEqual(window, globalThis);
testing.expectEqual(window, self);
testing.expectEqual(window, window.self);
testing.expectEqual(null, window.opener);
testing.expectEqual(1080, innerHeight);
testing.expectEqual(1920, innerWidth);

9
src/browser/webapi/Window.zig
View File

@@ -1,4 +1,4 @@
// Copyright (C) 2023-2025 Lightpanda (Selecy SAS)
// Copyright (C) 2023-2026 Lightpanda (Selecy SAS)
//
// Francis Bouvier <francis@lightpanda.io>
// Pierre Tachoire <pierre@lightpanda.io>
@@ -421,6 +421,12 @@ pub fn getScrollY(self: *const Window) u32 {
return self._scroll_pos.y;
}
pub fn getOpener(_: *const Window) ?*Window {
// This should return a window-like object in specific conditions. Would be
// pretty complicated to properly support I think.
return null;
}
const ScrollToOpts = union(enum) {
x: i32,
opts: Opts,
@@ -749,6 +755,7 @@ pub const JsApi = struct {
pub const pageYOffset = bridge.accessor(Window.getScrollY, null, .{ .cache = "pageYOffset" });
pub const scrollTo = bridge.function(Window.scrollTo, .{});
pub const scroll = bridge.function(Window.scrollTo, .{});
pub const opener = bridge.accessor(Window.getOpener, null, .{});
};
const testing = @import("../../testing.zig");