public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

support null params to CDP DOM.getDocument

Browse Source
This commit is contained in:
Karl Seguin
2025-07-17 19:05:17 +08:00
parent f199816fcd
commit eef5f3fec2
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/cdp/domains/dom.zig
View File

@@ -60,18 +60,19 @@ pub fn processMessage(cmd: anytype) !void {
// https://chromedevtools.github.io/devtools-protocol/tot/DOM/#method-getDocument // https://chromedevtools.github.io/devtools-protocol/tot/DOM/#method-getDocument
fn getDocument(cmd: anytype) !void { fn getDocument(cmd: anytype) !void {
const params = (try cmd.params(struct { const Params = struct {
// CDP documentation implies that 0 isn't valid, but it _does_ work in Chrome // CDP documentation implies that 0 isn't valid, but it _does_ work in Chrome
depth: ?i32 = null, depth: i32 = 3,
pierce: ?bool = null, pierce: bool = false,
})) orelse return error.InvalidParams; };
const params = try cmd.params(Params) orelse Params{};
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded; const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;
const page = bc.session.currentPage() orelse return error.PageNotLoaded; const page = bc.session.currentPage() orelse return error.PageNotLoaded;
const doc = parser.documentHTMLToDocument(page.window.document); const doc = parser.documentHTMLToDocument(page.window.document);
const node = try bc.node_registry.register(parser.documentToNode(doc)); const node = try bc.node_registry.register(parser.documentToNode(doc));
return cmd.sendResult(.{ .root = bc.nodeWriter(node, .{ .depth = params.depth orelse 3 }) }, .{}); return cmd.sendResult(.{ .root = bc.nodeWriter(node, .{ .depth = params.depth }) }, .{});
} }
// https://chromedevtools.github.io/devtools-protocol/tot/DOM/#method-performSearch // https://chromedevtools.github.io/devtools-protocol/tot/DOM/#method-performSearch
@@ -611,7 +612,6 @@ test "cdp.dom: getBoxModel" {
try ctx.processMessage(.{ // Hacky way to make sure nodeId 0 exists in the registry try ctx.processMessage(.{ // Hacky way to make sure nodeId 0 exists in the registry
.id = 3, .id = 3,
.method = "DOM.getDocument", .method = "DOM.getDocument",
.params = .{ .depth = 3 },
}); });
try ctx.processMessage(.{ try ctx.processMessage(.{