public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

cdp: add ParentId to Node.Writer

Browse Source
This commit is contained in:
Pierre Tachoire
2025-04-30 09:01:56 +02:00
parent 2910f4f527
commit f12a527ae3
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/cdp/Node.zig
View File

@@ -218,7 +218,7 @@ pub const Writer = struct {
fn toJSON(self: *const Writer, w: anytype) !void { fn toJSON(self: *const Writer, w: anytype) !void {
try w.beginObject(); try w.beginObject();
try writeCommon(self.node, false, w); try self.writeCommon(self.node, false, w);
{ {
var registry = self.registry; var registry = self.registry;
@@ -232,7 +232,7 @@ pub const Writer = struct {
const child = (try parser.nodeListItem(child_nodes, @intCast(i))) orelse break; const child = (try parser.nodeListItem(child_nodes, @intCast(i))) orelse break;
const child_node = try registry.register(child); const child_node = try registry.register(child);
try w.beginObject(); try w.beginObject();
try writeCommon(child_node, true, w); try self.writeCommon(child_node, true, w);
try w.endObject(); try w.endObject();
i += 1; i += 1;
} }
@@ -245,7 +245,7 @@ pub const Writer = struct {
try w.endObject(); try w.endObject();
} }
fn writeCommon(node: *const Node, include_child_count: bool, w: anytype) !void { fn writeCommon(self: *const Writer, node: *const Node, include_child_count: bool, w: anytype) !void {
try w.objectField("nodeId"); try w.objectField("nodeId");
try w.write(node.id); try w.write(node.id);
@@ -254,9 +254,11 @@ pub const Writer = struct {
const n = node._node; const n = node._node;
// TODO: if (try parser.nodeParentNode(n)) |p| {
// try w.objectField("parentId"); const parent_node = try self.registry.register(p);
// try w.write(pid); try w.objectField("parentId");
try w.write(parent_node.id);
}
try w.objectField("nodeType"); try w.objectField("nodeType");
try w.write(@intFromEnum(try parser.nodeType(n))); try w.write(@intFromEnum(try parser.nodeType(n)));
@@ -461,6 +463,7 @@ test "cdp Node: Writer" {
.xmlVersion = "", .xmlVersion = "",
.compatibilityMode = "NoQuirksMode", .compatibilityMode = "NoQuirksMode",
.isScrollable = false, .isScrollable = false,
.parentId = 1,
}, .{ }, .{
.nodeId = 3, .nodeId = 3,
.backendNodeId = 3, .backendNodeId = 3,
@@ -474,6 +477,7 @@ test "cdp Node: Writer" {
.xmlVersion = "", .xmlVersion = "",
.compatibilityMode = "NoQuirksMode", .compatibilityMode = "NoQuirksMode",
.isScrollable = false, .isScrollable = false,
.parentId = 1,
} }, } },
}, json); }, json);
} }