public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1824 from sjhddh/fix-option-gettext-leak

Browse Source 
fix: resolve memory leak in Option.getText() by using page arena
This commit is contained in:
Karl Seguin
2026-03-14 15:45:53 +08:00
committed by GitHub
parent 535128da71 c4176a282f
commit f4044230fd
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/SemanticTree.zig
View File

@@ -231,7 +231,7 @@ fn extractSelectOptions(node: *Node, page: *Page, arena: std.mem.Allocator) ![]O
if (child.is(Element)) |el| { if (child.is(Element)) |el| {
if (el.getTag() == .option) { if (el.getTag() == .option) {
if (el.is(Element.Html.Option)) |opt| { if (el.is(Element.Html.Option)) |opt| {
const text = opt.getText(); const text = opt.getText(page);
const value = opt.getValue(page); const value = opt.getValue(page);
const selected = opt.getSelected(); const selected = opt.getSelected();
try options.append(arena, .{ .text = text, .value = value, .selected = selected }); try options.append(arena, .{ .text = text, .value = value, .selected = selected });
@@ -240,7 +240,7 @@ fn extractSelectOptions(node: *Node, page: *Page, arena: std.mem.Allocator) ![]O
var group_it = child.childrenIterator(); var group_it = child.childrenIterator();
while (group_it.next()) |group_child| { while (group_it.next()) |group_child| {
if (group_child.is(Element.Html.Option)) |opt| { if (group_child.is(Element.Html.Option)) |opt| {
const text = opt.getText(); const text = opt.getText(page);
const value = opt.getValue(page); const value = opt.getValue(page);
const selected = opt.getSelected(); const selected = opt.getSelected();
try options.append(arena, .{ .text = text, .value = value, .selected = selected }); try options.append(arena, .{ .text = text, .value = value, .selected = selected });

5
src/browser/webapi/element/html/Option.zig
View File

@@ -61,10 +61,9 @@ pub fn setValue(self: *Option, value: []const u8, page: *Page) !void {
self._value = owned; self._value = owned;
} }
pub fn getText(self: *const Option) []const u8 { pub fn getText(self: *const Option, page: *Page) []const u8 {
const node: *Node = @constCast(self.asConstElement().asConstNode()); const node: *Node = @constCast(self.asConstElement().asConstNode());
const allocator = std.heap.page_allocator; // TODO: use proper allocator return node.getTextContentAlloc(page.call_arena) catch "";
return node.getTextContentAlloc(allocator) catch "";
} }
pub fn setText(self: *Option, value: []const u8, page: *Page) !void { pub fn setText(self: *Option, value: []const u8, page: *Page) !void {