public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Don't crash on success

Browse Source 
Keep request around, as the http/client needs it for cleanup. Calling abort
on an already deinit'd request is safe.
This commit is contained in:
Karl Seguin
2025-05-20 19:22:43 +08:00
parent 52634ddeb3
commit f42bd02cfc
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/browser/xhr/xhr.zig
View File

@@ -258,8 +258,7 @@ pub const XMLHttpRequest = struct {
}
pub fn destructor(self: *XMLHttpRequest, _: anytype) void {
const request = &(self.request orelse return);
request.abort();
self._abort();
}
pub fn reset(self: *XMLHttpRequest) void {
@@ -516,7 +515,6 @@ pub const XMLHttpRequest = struct {
return;
}
self.request = null;
self.state = .done;
self.send_flag = false;
self.dispatchEvt("readystatechange");
@@ -541,6 +539,10 @@ pub const XMLHttpRequest = struct {
}
pub fn _abort(self: *XMLHttpRequest) void {
const request = &(self.request orelse return);
// safe to call even if the request is complete
request.abort();
self.onErr(DOMError.Abort);
}