public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #1034 from lightpanda-io/persistent-promise
Some checks failed
e2e-test / zig build release (push) Has been cancelled
Details
e2e-test / demo-scripts (push) Has been cancelled
Details
e2e-test / cdp-and-hyperfine-bench (push) Has been cancelled
Details
e2e-test / perf-fmt (push) Has been cancelled
Details
zig-test / zig build dev (push) Has been cancelled
Details
zig-test / browser fetch (push) Has been cancelled
Details
zig-test / zig test (push) Has been cancelled
Details
zig-test / perf-fmt (push) Has been cancelled
Details

Browse Source 
Clean Up Persistent Promises in Dynamic Import
This commit is contained in:
Karl Seguin
2025-09-10 08:39:50 +08:00
committed by GitHub
parent cdc439c4ef 7eb53ca2bc
commit f464e89415
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/runtime/js.zig
View File

@@ -1689,6 +1689,11 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
specifier: []const u8, specifier: []const u8,
module: v8.Persistent(v8.Module), module: v8.Persistent(v8.Module),
resolver: v8.Persistent(v8.PromiseResolver), resolver: v8.Persistent(v8.PromiseResolver),
pub fn deinit(ev: *@This()) void {
ev.module.deinit();
ev.resolver.deinit();
}
}; };
const ev_data = try self.context_arena.create(EvaluationData); const ev_data = try self.context_arena.create(EvaluationData);
@@ -1705,6 +1710,7 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
const cb_isolate = cb_info.getIsolate(); const cb_isolate = cb_info.getIsolate();
const cb_context = cb_isolate.getCurrentContext(); const cb_context = cb_isolate.getCurrentContext();
const data: *EvaluationData = @ptrCast(@alignCast(cb_info.getExternalValue())); const data: *EvaluationData = @ptrCast(@alignCast(cb_info.getExternalValue()));
defer data.deinit();
const cb_module = data.module.castToModule(); const cb_module = data.module.castToModule();
const cb_resolver = data.resolver.castToPromiseResolver(); const cb_resolver = data.resolver.castToPromiseResolver();
@@ -1719,6 +1725,7 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
const cb_info = v8.FunctionCallbackInfo{ .handle = info.? }; const cb_info = v8.FunctionCallbackInfo{ .handle = info.? };
const cb_context = cb_info.getIsolate().getCurrentContext(); const cb_context = cb_info.getIsolate().getCurrentContext();
const data: *EvaluationData = @ptrCast(@alignCast(cb_info.getExternalValue())); const data: *EvaluationData = @ptrCast(@alignCast(cb_info.getExternalValue()));
defer data.deinit();
const cb_resolver = data.resolver.castToPromiseResolver(); const cb_resolver = data.resolver.castToPromiseResolver();
log.err(.js, "dynamic import failed", .{ .specifier = data.specifier }); log.err(.js, "dynamic import failed", .{ .specifier = data.specifier });
@@ -1731,6 +1738,7 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
.specifier = specifier, .specifier = specifier,
.line = try_catch.sourceLineNumber() orelse 0, .line = try_catch.sourceLineNumber() orelse 0,
}); });
defer ev_data.deinit();
const error_msg = v8.String.initUtf8(iso, "Evaluation is a promise"); const error_msg = v8.String.initUtf8(iso, "Evaluation is a promise");
_ = resolver.reject(ctx, error_msg.toValue()); _ = resolver.reject(ctx, error_msg.toValue());
return; return;