public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-21 20:24:42 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

lp: validate params in node actions and rename variables

Browse Source
This commit is contained in:
Adrià Arrufat
2026-03-16 23:50:15 +09:00
parent 548c6eeb7a
commit f508d37426
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/cdp/domains/lp.zig
View File

@@ -157,13 +157,13 @@ fn clickNode(cmd: anytype) !void {
nodeId: ?Node.Id = null, nodeId: ?Node.Id = null,
backendNodeId: ?Node.Id = null, backendNodeId: ?Node.Id = null,
}; };
const params = (try cmd.params(Params)) orelse Params{}; const params = (try cmd.params(Params)) orelse return error.InvalidParam;
const bc = cmd.browser_context orelse return error.NoBrowserContext; const bc = cmd.browser_context orelse return error.NoBrowserContext;
const page = bc.session.currentPage() orelse return error.PageNotLoaded; const page = bc.session.currentPage() orelse return error.PageNotLoaded;
const input_node_id = params.nodeId orelse params.backendNodeId orelse return error.InvalidParam; const node_id = params.nodeId orelse params.backendNodeId orelse return error.InvalidParam;
const node = bc.node_registry.lookup_by_id.get(input_node_id) orelse return error.InvalidNodeId; const node = bc.node_registry.lookup_by_id.get(node_id) orelse return error.InvalidNodeId;
lp.actions.click(node.dom, page) catch |err| { lp.actions.click(node.dom, page) catch |err| {
if (err == error.InvalidNodeType) return error.InvalidParam; if (err == error.InvalidNodeType) return error.InvalidParam;
@@ -184,8 +184,8 @@ fn fillNode(cmd: anytype) !void {
const bc = cmd.browser_context orelse return error.NoBrowserContext; const bc = cmd.browser_context orelse return error.NoBrowserContext;
const page = bc.session.currentPage() orelse return error.PageNotLoaded; const page = bc.session.currentPage() orelse return error.PageNotLoaded;
const input_node_id = params.nodeId orelse params.backendNodeId orelse return error.InvalidParam; const node_id = params.nodeId orelse params.backendNodeId orelse return error.InvalidParam;
const node = bc.node_registry.lookup_by_id.get(input_node_id) orelse return error.InvalidNodeId; const node = bc.node_registry.lookup_by_id.get(node_id) orelse return error.InvalidNodeId;
lp.actions.fill(node.dom, params.text, page) catch |err| { lp.actions.fill(node.dom, params.text, page) catch |err| {
if (err == error.InvalidNodeType) return error.InvalidParam; if (err == error.InvalidNodeType) return error.InvalidParam;
@@ -202,15 +202,15 @@ fn scrollNode(cmd: anytype) !void {
x: ?i32 = null, x: ?i32 = null,
y: ?i32 = null, y: ?i32 = null,
}; };
const params = (try cmd.params(Params)) orelse Params{}; const params = (try cmd.params(Params)) orelse return error.InvalidParam;
const bc = cmd.browser_context orelse return error.NoBrowserContext; const bc = cmd.browser_context orelse return error.NoBrowserContext;
const page = bc.session.currentPage() orelse return error.PageNotLoaded; const page = bc.session.currentPage() orelse return error.PageNotLoaded;
const input_node_id = params.nodeId orelse params.backendNodeId; const maybe_node_id = params.nodeId orelse params.backendNodeId;
var target_node: ?*DOMNode = null; var target_node: ?*DOMNode = null;
if (input_node_id) |node_id| { if (maybe_node_id) |node_id| {
const node = bc.node_registry.lookup_by_id.get(node_id) orelse return error.InvalidNodeId; const node = bc.node_registry.lookup_by_id.get(node_id) orelse return error.InvalidNodeId;
target_node = node.dom; target_node = node.dom;
} }