public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-04-02 10:19:17 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

different cache crash prevention

Browse Source
This commit is contained in:
Muki Kiboigo
2026-04-02 03:11:16 -07:00
parent d18acd5228
commit f558139497
1 changed files with 20 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/browser/ScriptManager.zig
View File

@@ -273,11 +273,18 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
// Let the outer errdefer handle releasing the arena if client.request fails
}
// If we return synchronously (like from cache), we would call evaluate() immediately.
{
const was_evaluating = self.is_evaluating;
self.is_evaluating = true;
defer self.is_evaluating = was_evaluating;
if (comptime IS_DEBUG) {
var ls: js.Local.Scope = undefined;
page.js.localScope(&ls);
defer ls.deinit();
log.debug(.http, "script queue", .{
.ctx = ctx,
.url = remote_url.?,
.element = element,
.stack = ls.local.stackTrace() catch "???",
});
}
try self.client.request(.{
.url = url,
@@ -296,22 +303,8 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
.done_callback = Script.doneCallback,
.error_callback = Script.errorCallback,
});
}
handover = true;
if (comptime IS_DEBUG) {
var ls: js.Local.Scope = undefined;
page.js.localScope(&ls);
defer ls.deinit();
log.debug(.http, "script queue", .{
.ctx = ctx,
.url = remote_url.?,
.element = element,
.stack = ls.local.stackTrace() catch "???",
});
}
}
if (is_blocking == false) {