public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix gc_hints not being send

Browse Source
This commit is contained in:
sjorsdonkers
2025-05-02 15:06:21 +02:00
parent cddc55694a
commit f6f744aea1
1 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/runtime/js.zig
View File

@@ -301,22 +301,21 @@ pub fn Env(comptime S: type, comptime types: anytype) type {
// no init, must be initialized via env.newExecutor() // no init, must be initialized via env.newExecutor()
pub fn deinit(self: *Executor) void { pub fn deinit(self: *Executor) void {
if (self.scope) |scope| { if (self.scope != null) {
const isolate = scope.isolate;
self.endScope(); self.endScope();
}
// V8 doesn't immediately free memory associated with // V8 doesn't immediately free memory associated with
// a Context, it's managed by the garbage collector. So, when the // a Context, it's managed by the garbage collector. So, when the
// `gc_hints` option is enabled, we'll use the `lowMemoryNotification` // `gc_hints` option is enabled, we'll use the `lowMemoryNotification`
// call on the isolate to encourage v8 to free any contexts which // call on the isolate to encourage v8 to free any contexts which
// have been freed. // have been freed.
if (self.env.gc_hints) { if (self.env.gc_hints) {
var handle_scope: v8.HandleScope = undefined; var handle_scope: v8.HandleScope = undefined;
v8.HandleScope.init(&handle_scope, isolate); v8.HandleScope.init(&handle_scope, self.env.isolate);
defer handle_scope.deinit(); defer handle_scope.deinit();
self.env.isolate.lowMemoryNotification(); self.env.isolate.lowMemoryNotification(); // TODO we only need to call this for the main World Executor
}
} }
self.call_arena.deinit(); self.call_arena.deinit();
self.scope_arena.deinit(); self.scope_arena.deinit();