public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Force dynamic module instantiation if not already instantiated

Browse Source 
I couldn't come up with a reproducible case where this was needed, but we're
seeing some crash reports indicate that this is happening.
This commit is contained in:
Karl Seguin
2026-03-04 16:10:42 +08:00
parent bc8c44f62f
commit f7682cba67
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/browser/js/Context.zig
View File

@@ -786,9 +786,16 @@ fn _dynamicModuleCallback(self: *Context, specifier: [:0]const u8, referrer: []c
entry.module_promise = try module_resolver.promise().persist(); entry.module_promise = try module_resolver.promise().persist();
} else { } else {
// the module was loaded, but not evaluated, we _have_ to evaluate it now // the module was loaded, but not evaluated, we _have_ to evaluate it now
if (status == .kUninstantiated) {
if (try mod.instantiate(resolveModuleCallback) == false) {
_ = resolver.reject("module instantiation", local.newString("Module instantiation failed"));
return promise;
}
}
const evaluated = mod.evaluate() catch { const evaluated = mod.evaluate() catch {
if (comptime IS_DEBUG) { if (comptime IS_DEBUG) {
std.debug.assert(status == .kErrored); std.debug.assert(mod.getStatus() == .kErrored);
} }
_ = resolver.reject("module evaluation", local.newString("Module evaluation failed")); _ = resolver.reject("module evaluation", local.newString("Module evaluation failed"));
return promise; return promise;