From fae2b5acfa04aaa3e1b77824ab0cb8963be02c7f Mon Sep 17 00:00:00 2001
From: Karl Seguin <k@openmymind.io>
Date: Mon, 14 Jul 2025 11:21:02 +0800
Subject: [PATCH] Noop CDP methods that go-rod requires

go-rod appears to stop processing when it receives an error, such as
UnknownMethod. Added placeholder handlers for Network.setUserAgentOverride and
Page.stopLoading.

Setting a custom user agent is something still being discussed, so no-oping it
seems reasonable. And, due to the currently synchronous nature of the initial
page load, no-oping stopLoading also seems reasonable.

https://github.com/lightpanda-io/browser/issues/867
---
 src/cdp/domains/network.zig | 2 ++
 src/cdp/domains/page.zig    | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/src/cdp/domains/network.zig b/src/cdp/domains/network.zig
index 7a5cd02b..bc8b80a4 100644
--- a/src/cdp/domains/network.zig
+++ b/src/cdp/domains/network.zig
@@ -29,6 +29,7 @@ pub fn processMessage(cmd: anytype) !void {
         disable,
         setCacheDisabled,
         setExtraHTTPHeaders,
+        setUserAgentOverride,
         deleteCookies,
         clearBrowserCookies,
         setCookie,
@@ -40,6 +41,7 @@ pub fn processMessage(cmd: anytype) !void {
         .enable => return enable(cmd),
         .disable => return disable(cmd),
         .setCacheDisabled => return cmd.sendResult(null, .{}),
+        .setUserAgentOverride => return cmd.sendResult(null, .{}),
         .setExtraHTTPHeaders => return setExtraHTTPHeaders(cmd),
         .deleteCookies => return deleteCookies(cmd),
         .clearBrowserCookies => return clearBrowserCookies(cmd),
diff --git a/src/cdp/domains/page.zig b/src/cdp/domains/page.zig
index 368a3b51..5ffdca2d 100644
--- a/src/cdp/domains/page.zig
+++ b/src/cdp/domains/page.zig
@@ -31,6 +31,7 @@ pub fn processMessage(cmd: anytype) !void {
         addScriptToEvaluateOnNewDocument,
         createIsolatedWorld,
         navigate,
+        stopLoading,
     }, cmd.input.action) orelse return error.UnknownMethod;
 
     switch (action) {
@@ -40,6 +41,7 @@ pub fn processMessage(cmd: anytype) !void {
         .addScriptToEvaluateOnNewDocument => return addScriptToEvaluateOnNewDocument(cmd),
         .createIsolatedWorld => return createIsolatedWorld(cmd),
         .navigate => return navigate(cmd),
+        .stopLoading => return cmd.sendResult(null, .{}),
     }
 }