From a8a5605fe18fd01e85d61afd49be2bb8e74a2b27 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Fri, 13 Jun 2025 19:16:54 +0200 Subject: [PATCH 1/3] typo fix --- src/browser/url/url.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/url/url.zig b/src/browser/url/url.zig index 9ec1e04b..6d31d3c5 100644 --- a/src/browser/url/url.zig +++ b/src/browser/url/url.zig @@ -48,7 +48,7 @@ pub const Interfaces = .{ // allocatorate data, I should be able to retrieve the scheme + the following `:` // from rawuri. // -// 2. The other way would bu to copy the `std.Uri` code to ahve a dedicated +// 2. The other way would be to copy the `std.Uri` code to have a dedicated // parser including the characters we want for the web API. pub const URL = struct { uri: std.Uri, From 63541970eb186903225ae710f1f4eeb692511a71 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Fri, 13 Jun 2025 19:17:07 +0200 Subject: [PATCH 2/3] handle null scriptname in stack trace --- src/runtime/js.zig | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/runtime/js.zig b/src/runtime/js.zig index 6cea2b21..86619c6a 100644 --- a/src/runtime/js.zig +++ b/src/runtime/js.zig @@ -3214,8 +3214,12 @@ fn stackForLogs(arena: Allocator, isolate: v8.Isolate) !?[]const u8 { for (0..frame_count) |i| { const frame = stack_trace.getFrame(isolate, @intCast(i)); - const script = try jsStringToZig(arena, frame.getScriptName(), isolate); - try writer.print("{s}{s}:{d}", .{ separator, script, frame.getLineNumber() }); + if (frame.getScriptName()) |name| { + const script = try jsStringToZig(arena, name, isolate); + try writer.print("{s}{s}:{d}", .{ separator, script, frame.getLineNumber() }); + } else { + try writer.print("{s}:{d}", .{ separator, frame.getLineNumber() }); + } } return buf.items; } From 02c510b07fc69983d4e81d71dbd375a4ca564f86 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Fri, 13 Jun 2025 19:19:10 +0200 Subject: [PATCH 3/3] upgrade zig-v8 --- build.zig.zon | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build.zig.zon b/build.zig.zon index c2299d4b..aa143f89 100644 --- a/build.zig.zon +++ b/build.zig.zon @@ -13,8 +13,8 @@ .hash = "tigerbeetle_io-0.0.0-ViLgxpyRBAB5BMfIcj3KMXfbJzwARs9uSl8aRy2OXULd", }, .v8 = .{ - .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/faab44996a5cb74c71592bda404208fde4bf2e63.tar.gz", - .hash = "v8-0.0.0-xddH6xWyAwB_NFICSO4Q3O-c7gDKnYiwky5FhQzTZMIr", + .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/1d25fcf3ced688adca3c7a95a138771e4ebba692.tar.gz", + .hash = "v8-0.0.0-xddH61eyAwDICIkLAkfQcxsX4TMCKY80QiSUgNBQqx-u", }, //.v8 = .{ .path = "../zig-v8-fork" }, //.tigerbeetle_io = .{ .path = "../tigerbeetle-io" },