public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 12:44:43 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

cdp: handle STARTUP session into Page.getFrameTree gracefully

Browse Source
This commit is contained in:
Pierre Tachoire
2026-03-21 16:21:59 +01:00
parent 384b2f7614
commit fbc71d6ff7
2 changed files with 53 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
src/cdp/cdp.zig
View File

@@ -189,27 +189,10 @@ pub fn CDPT(comptime TypeProvider: type) type {
// (I can imagine this logic will become driver-specific)
fn dispatchStartupCommand(command: anytype, method: []const u8) !void {
// Stagehand parses the response and error if we don't return a
// correct one for this call.
// correct one for Page.getFrameTree on startup call.
if (std.mem.eql(u8, method, "Page.getFrameTree")) {
// If we have a brower context and a target id, we can call the
// real dispatch command, even during STARTUP.
if (command.cdp.browser_context) |*bc| {
if (bc.target_id != null) {
return dispatchCommand(command, method);
}
}
return command.sendResult(.{
.frameTree = .{
.frame = .{
.id = "TID-STARTUP",
.loaderId = "LID-STARTUP",
.securityOrigin = URL_BASE,
.url = "about:blank",
.secureContextType = "Secure",
},
},
}, .{});
// The Page.getFrameTree handles startup response gracefully.
return dispatchCommand(command, method);
}
return command.sendResult(null, .{});
@@ -995,47 +978,3 @@ test "cdp: STARTUP sessionId" {
try ctx.expectSentResult(null, .{ .id = 4, .index = 0, .session_id = "STARTUP" });
}
}
test "cdp: STARTUP getFrameTree returns real frame ID when page exists" {
var ctx = testing.context();
defer ctx.deinit();
{
// no browser context - should return TID-STARTUP
try ctx.processMessage(.{ .id = 1, .method = "Page.getFrameTree", .sessionId = "STARTUP" });
try ctx.expectSentResult(.{
.frameTree = .{
.frame = .{
.id = "TID-STARTUP",
.loaderId = "LID-STARTUP",
.url = "about:blank",
.secureContextType = "Secure",
},
},
}, .{ .id = 1, .session_id = "STARTUP" });
}
{
// browser context with target_id - should return real frame ID
const bc = try ctx.loadBrowserContext(.{ .target_id = "TID-000000000X".* });
try ctx.processMessage(.{ .id = 2, .method = "Page.getFrameTree", .sessionId = "STARTUP" });
try ctx.expectSentResult(.{
.frameTree = .{
.frame = .{
.id = "TID-000000000X",
.loaderId = "LID-0000000001",
.url = "about:blank",
.domainAndRegistry = "",
.securityOrigin = bc.security_origin,
.mimeType = "text/html",
.adFrameStatus = .{
.adFrameType = "none",
},
.secureContextType = bc.secure_context_type,
.crossOriginIsolatedContextType = "NotIsolated",
.gatedAPIFeatures = [_][]const u8{},
},
},
}, .{ .id = 2, .session_id = "STARTUP" });
}
}