public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Use std.Atomic.Value in Server instead of direct atomic operations

Browse Source
This commit is contained in:
Nikolay Govorov
2026-02-17 12:24:18 +00:00
parent ccbb6e4789
commit fbe65cd542
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Server.zig
View File

@@ -34,7 +34,7 @@ const CDP = @import("cdp/cdp.zig").CDP;
const Server = @This(); const Server = @This();
app: *App, app: *App,
shutdown: bool = false, shutdown: std.atomic.Value(bool) = .init(false),
allocator: Allocator, allocator: Allocator,
client: ?posix.socket_t, client: ?posix.socket_t,
listener: ?posix.socket_t, listener: ?posix.socket_t,
@@ -56,7 +56,7 @@ pub fn init(app: *App, address: net.Address) !Server {
/// Interrupts the server so that main can complete normally and call all defer handlers. /// Interrupts the server so that main can complete normally and call all defer handlers.
pub fn stop(self: *Server) void { pub fn stop(self: *Server) void {
if (@atomicRmw(bool, &self.shutdown, .Xchg, true, .monotonic)) { if (self.shutdown.swap(true, .release)) {
return; return;
} }
@@ -76,6 +76,10 @@ pub fn stop(self: *Server) void {
} }
pub fn deinit(self: *Server) void { pub fn deinit(self: *Server) void {
if (!self.shutdown.load(.acquire)) {
self.stop();
}
if (self.listener) |listener| { if (self.listener) |listener| {
posix.close(listener); posix.close(listener);
self.listener = null; self.listener = null;
@@ -99,7 +103,7 @@ pub fn run(self: *Server, address: net.Address, timeout_ms: u32) !void {
try posix.listen(listener, 1); try posix.listen(listener, 1);
log.info(.app, "server running", .{ .address = address }); log.info(.app, "server running", .{ .address = address });
while (!@atomicLoad(bool, &self.shutdown, .monotonic)) { while (!self.shutdown.load(.acquire)) {
const socket = posix.accept(listener, null, null, posix.SOCK.NONBLOCK) catch |err| { const socket = posix.accept(listener, null, null, posix.SOCK.NONBLOCK) catch |err| {
switch (err) { switch (err) {
error.SocketNotListening, error.ConnectionAborted => { error.SocketNotListening, error.ConnectionAborted => {