Merge pull request #2068 from lightpanda-io/refactor/markdown-anchor-rendering

markdown: simplify and optimize anchor rendering

build.zig

@@ -46,8 +46,12 @@ pub fn build(b: *Build) !void {
     var stdout = std.fs.File.stdout().writer(&.{});
     try stdout.interface.print("Lightpanda {f}\n", .{version});
 
+    const version_string = b.fmt("{f}", .{version});
+    const version_encoded = std.mem.replaceOwned(u8, b.allocator, version_string, "+", "%2B") catch @panic("OOM");
+
     var opts = b.addOptions();
-    opts.addOption([]const u8, "version", b.fmt("{f}", .{version}));
+    opts.addOption([]const u8, "version", version_string);
+    opts.addOption([]const u8, "version_encoded", version_encoded);
     opts.addOption(?[]const u8, "snapshot_path", snapshot_path);
 
     const enable_tsan = b.option(bool, "tsan", "Enable Thread Sanitizer") orelse false;
@@ -85,6 +89,15 @@ pub fn build(b: *Build) !void {
         break :blk mod;
     };
 
+    // Check compilation
+    const check = b.step("check", "Check if lightpanda compiles");
+
+    const check_lib = b.addLibrary(.{
+        .name = "lightpanda_check",
+        .root_module = lightpanda_module,
+    });
+    check.dependOn(&check_lib.step);
+
     {
         // browser
         const exe = b.addExecutable(.{
@@ -103,6 +116,12 @@ pub fn build(b: *Build) !void {
         });
         b.installArtifact(exe);
 
+        const exe_check = b.addLibrary(.{
+            .name = "lightpanda_exe_check",
+            .root_module = exe.root_module,
+        });
+        check.dependOn(&exe_check.step);
+
         const run_cmd = b.addRunArtifact(exe);
         if (b.args) |args| {
             run_cmd.addArgs(args);
@@ -132,6 +151,12 @@ pub fn build(b: *Build) !void {
         });
         b.installArtifact(exe);
 
+        const exe_check = b.addLibrary(.{
+            .name = "snapshot_creator_check",
+            .root_module = exe.root_module,
+        });
+        check.dependOn(&exe_check.step);
+
         const run_cmd = b.addRunArtifact(exe);
         if (b.args) |args| {
             run_cmd.addArgs(args);
@@ -170,6 +195,12 @@ pub fn build(b: *Build) !void {
         });
         b.installArtifact(exe);
 
+        const exe_check = b.addLibrary(.{
+            .name = "legacy_test_check",
+            .root_module = exe.root_module,
+        });
+        check.dependOn(&exe_check.step);
+
         const run_cmd = b.addRunArtifact(exe);
         if (b.args) |args| {
             run_cmd.addArgs(args);

src/browser/markdown.zig

@@ -25,9 +25,7 @@ const Element = @import("webapi/Element.zig");
 const Node = @import("webapi/Node.zig");
 const isAllWhitespace = @import("../string.zig").isAllWhitespace;
 
-pub const Opts = struct {
+pub const Opts = struct {};
-    // Options for future customization (e.g., dialect)
-};
 
 const State = struct {
     const ListType = enum { ordered, unordered };
@@ -39,7 +37,6 @@ const State = struct {
     list_depth: usize = 0,
     list_stack: [32]ListState = undefined,
     pre_node: ?*Node = null,
-    in_code: bool = false,
     in_table: bool = false,
     table_row_index: usize = 0,
     table_col_count: usize = 0,
@@ -100,27 +97,35 @@ fn getAnchorLabel(el: *Element) ?[]const u8 {
     return el.getAttributeSafe(comptime .wrap("aria-label")) orelse el.getAttributeSafe(comptime .wrap("title"));
 }
 
-fn hasBlockDescendant(root: *Node) bool {
+const ContentInfo = struct {
-    var tw = TreeWalker.FullExcludeSelf.Elements.init(root, .{});
+    has_visible: bool,
-    while (tw.next()) |el| {
+    has_block: bool,
-        if (el.getTag().isBlock()) return true;
+};
-    }
-    return false;
-}
 
-fn hasVisibleContent(root: *Node) bool {
+fn analyzeContent(root: *Node) ContentInfo {
+    var result: ContentInfo = .{ .has_visible = false, .has_block = false };
     var tw = TreeWalker.FullExcludeSelf.init(root, .{});
     while (tw.next()) |node| {
-        if (isSignificantText(node)) return true;
+        if (isSignificantText(node)) {
-        if (node.is(Element)) |el| {
+            result.has_visible = true;
+            if (result.has_block) return result;
+        } else if (node.is(Element)) |el| {
             if (!isVisibleElement(el)) {
                 tw.skipChildren();
-            } else if (el.getTag() == .img) {
+            } else {
-                return true;
+                const tag = el.getTag();
+                if (tag == .img) {
+                    result.has_visible = true;
+                    if (result.has_block) return result;
+                }
+                if (tag.isBlock()) {
+                    result.has_block = true;
+                    if (result.has_visible) return result;
+                }
             }
         }
     }
-    return false;
+    return result;
 }
 
 const Context = struct {
@@ -170,9 +175,7 @@ const Context = struct {
 
         if (!isVisibleElement(el)) return;
 
-        // --- Opening Tag Logic ---
+        // Ensure block elements start on a new line
-
-        // Ensure block elements start on a new line (double newline for paragraphs etc)
         if (tag.isBlock() and !self.state.in_table) {
             try self.ensureNewline();
             if (shouldAddSpacing(tag)) {
@@ -182,7 +185,6 @@ const Context = struct {
             try self.ensureNewline();
         }
 
-        // Prefixes
         switch (tag) {
             .h1 => try self.writer.writeAll("# "),
             .h2 => try self.writer.writeAll("## "),
@@ -225,7 +227,6 @@ const Context = struct {
                 try self.writer.writeByte('|');
             },
             .td, .th => {
-                // Note: leading pipe handled by previous cell closing or tr opening
                 self.state.last_char_was_newline = false;
                 try self.writer.writeByte(' ');
             },
@@ -241,7 +242,6 @@ const Context = struct {
             .code => {
                 if (self.state.pre_node == null) {
                     try self.writer.writeByte('`');
-                    self.state.in_code = true;
                     self.state.last_char_was_newline = false;
                 }
             },
@@ -286,16 +286,15 @@ const Context = struct {
                 return;
             },
             .anchor => {
-                const has_content = hasVisibleContent(el.asNode());
+                const info = analyzeContent(el.asNode());
                 const label = getAnchorLabel(el);
                 const href_raw = el.getAttributeSafe(comptime .wrap("href"));
 
-                if (!has_content and label == null and href_raw == null) return;
+                if (!info.has_visible and label == null and href_raw == null) return;
 
-                const has_block = hasBlockDescendant(el.asNode());
                 const href = if (href_raw) |h| URL.resolve(self.page.call_arena, self.page.base(), h, .{ .encode = true }) catch h else null;
 
-                if (has_block) {
+                if (info.has_block) {
                     try self.renderChildren(el.asNode());
                     if (href) |h| {
                         if (!self.state.last_char_was_newline) try self.writer.writeByte('\n');
@@ -307,25 +306,12 @@ const Context = struct {
                     return;
                 }
 
-                if (isStandaloneAnchor(el)) {
+                const standalone = isStandaloneAnchor(el);
+                if (standalone) {
                     if (!self.state.last_char_was_newline) try self.writer.writeByte('\n');
-                    try self.writer.writeByte('[');
-                    if (has_content) {
-                        try self.renderChildren(el.asNode());
-                    } else {
-                        try self.writer.writeAll(label orelse "");
-                    }
-                    try self.writer.writeAll("](");
-                    if (href) |h| {
-                        try self.writer.writeAll(h);
-                    }
-                    try self.writer.writeAll(")\n");
-                    self.state.last_char_was_newline = true;
-                    return;
                 }
-
                 try self.writer.writeByte('[');
-                if (has_content) {
+                if (info.has_visible) {
                     try self.renderChildren(el.asNode());
                 } else {
                     try self.writer.writeAll(label orelse "");
@@ -335,7 +321,12 @@ const Context = struct {
                     try self.writer.writeAll(h);
                 }
                 try self.writer.writeByte(')');
-                self.state.last_char_was_newline = false;
+                if (standalone) {
+                    try self.writer.writeByte('\n');
+                    self.state.last_char_was_newline = true;
+                } else {
+                    self.state.last_char_was_newline = false;
+                }
                 return;
             },
             .input => {
@@ -350,12 +341,8 @@ const Context = struct {
             else => {},
         }
 
-        // --- Render Children ---
         try self.renderChildren(el.asNode());
 
-        // --- Closing Tag Logic ---
-
-        // Suffixes
         switch (tag) {
             .pre => {
                 if (!self.state.last_char_was_newline) {
@@ -368,7 +355,6 @@ const Context = struct {
             .code => {
                 if (self.state.pre_node == null) {
                     try self.writer.writeByte('`');
-                    self.state.in_code = false;
                     self.state.last_char_was_newline = false;
                 }
             },
@@ -411,7 +397,6 @@ const Context = struct {
             else => {},
         }
 
-        // Post-block newlines
         if (tag.isBlock() and !self.state.in_table) {
             try self.ensureNewline();
         }
@@ -454,15 +439,19 @@ const Context = struct {
     }
 
     fn escape(self: *Context, text: []const u8) !void {
-        for (text) |c| {
+        var start: usize = 0;
+        for (text, 0..) |c, i| {
             switch (c) {
                 '\\', '`', '*', '_', '{', '}', '[', ']', '(', ')', '#', '+', '-', '!', '|' => {
+                    if (i > start) try self.writer.writeAll(text[start..i]);
                     try self.writer.writeByte('\\');
                     try self.writer.writeByte(c);
+                    start = i + 1;
                 },
-                else => try self.writer.writeByte(c),
+                else => {},
             }
         }
+        if (start < text.len) try self.writer.writeAll(text[start..]);
     }
 };
 

src/crash_handler.zig

@@ -86,7 +86,7 @@ fn report(reason: []const u8, begin_addr: usize, args: anytype) !void {
     var url_buffer: [4096]u8 = undefined;
     const url = blk: {
         var writer: std.Io.Writer = .fixed(&url_buffer);
-        try writer.print("https://crash.lightpanda.io/c?v={s}&r=", .{lp.build_config.version});
+        try writer.print("https://crash.lightpanda.io/c?v={s}&r=", .{lp.build_config.version_encoded});
         for (reason) |b| {
             switch (b) {
                 'A'...'Z', 'a'...'z', '0'...'9', '-', '.', '_' => try writer.writeByte(b),