public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

page: ensure page navigate events order

Browse Source
This commit is contained in:
Pierre Tachoire
2025-08-27 17:30:06 +02:00
parent 545d3f81ce
commit 036f808ec6
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/browser/page.zig
View File

@@ -520,6 +520,14 @@ pub const Page = struct {
if (opts.header) |hdr| try headers.add(hdr); if (opts.header) |hdr| try headers.add(hdr);
try self.requestCookie(.{ .is_navigation = true }).headersForRequest(self.arena, owned_url, &headers); try self.requestCookie(.{ .is_navigation = true }).headersForRequest(self.arena, owned_url, &headers);
// We dispatch page_navigate event before sending the request.
// It ensures the event page_navigated is not dispatched before this one.
self.session.browser.notification.dispatch(.page_navigate, &.{
.opts = opts,
.url = owned_url,
.timestamp = timestamp(),
});
self.http_client.request(.{ self.http_client.request(.{
.ctx = self, .ctx = self,
.url = owned_url, .url = owned_url,
@@ -536,12 +544,6 @@ pub const Page = struct {
log.err(.http, "navigate request", .{ .url = owned_url, .err = err }); log.err(.http, "navigate request", .{ .url = owned_url, .err = err });
return err; return err;
}; };
self.session.browser.notification.dispatch(.page_navigate, &.{
.opts = opts,
.url = owned_url,
.timestamp = timestamp(),
});
} }
pub fn setCurrentScript(self: *Page, script: ?*parser.Script) !void { pub fn setCurrentScript(self: *Page, script: ?*parser.Script) !void {