public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-12-14 15:28:57 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

backport the resolve/stitch regression test

Browse Source
This commit is contained in:
Muki Kiboigo
2025-12-08 05:16:45 -08:00
parent 370c3a49a7
commit 0e4cfbfe6b
1 changed files with 24 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/browser/URL.zig
View File

@@ -68,9 +68,11 @@ pub fn resolve(allocator: Allocator, base: [:0]const u8, path: anytype, comptime
return std.mem.joinZ(allocator, "", &.{ base[0..path_start], path });
}
var normalized_base: []const u8 = base;
if (std.mem.lastIndexOfScalar(u8, normalized_base[authority_start..], '/')) |pos| {
normalized_base = normalized_base[0 .. pos + authority_start];
var normalized_base: []const u8 = base[0..path_start];
if (path_start < base.len) {
if (std.mem.lastIndexOfScalar(u8, base[path_start + 1 ..], '/')) |pos| {
normalized_base = base[0 .. path_start + 1 + pos];
}
}
// trailing space so that we always have space to append the null terminator
@@ -297,29 +299,28 @@ test "URL: isCompleteHTTPUrl" {
try testing.expectEqual(false, isCompleteHTTPUrl("about"));
}
// TODO: uncomment
// test "URL: resolve regression (#1093)" {
// defer testing.reset();
test "URL: resolve regression (#1093)" {
defer testing.reset();
// const Case = struct {
// base: []const u8,
// path: []const u8,
// expected: []const u8,
// };
const Case = struct {
base: [:0]const u8,
path: [:0]const u8,
expected: [:0]const u8,
};
// const cases = [_]Case{
// .{
// .base = "https://alas.aws.amazon.com/alas2.html",
// .path = "../static/bootstrap.min.css",
// .expected = "https://alas.aws.amazon.com/static/bootstrap.min.css",
// },
// };
const cases = [_]Case{
.{
.base = "https://alas.aws.amazon.com/alas2.html",
.path = "../static/bootstrap.min.css",
.expected = "https://alas.aws.amazon.com/static/bootstrap.min.css",
},
};
// for (cases) |case| {
// const result = try resolve(testing.arena_allocator, case.path, case.base, .{});
// try testing.expectString(case.expected, result);
// }
// }
for (cases) |case| {
const result = try resolve(testing.arena_allocator, case.base, case.path, .{});
try testing.expectString(case.expected, result);
}
}
test "URL: resolve" {
defer testing.reset();