public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

move page error HTML creation into pageDoneCallback

Browse Source 
Now pageErrCllaback call pageDoneCallback to finalize the page.
This commit is contained in:
Pierre Tachoire
2026-02-17 09:47:45 +01:00
parent 311bcadacb
commit 14b0095822
1 changed files with 19 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/browser/Page.zig
View File

@@ -789,6 +789,21 @@ fn pageDoneCallback(ctx: *anyopaque) !void {
self._parse_state = .{ .complete = {} };
self.documentIsComplete();
},
.err => |err| {
// Generate a pseudo HTML page indicating the failure.
const parse_arena = try self.getArena(.{ .debug = "Page.parse" });
defer self.releaseArena(parse_arena);
const html = std.mem.concat(parse_arena, u8, &.{
"<html><head><meta charset=\"utf-8\"></head><body><h1>Navigation failed</h1><p>Reason: ",
@errorName(err),
"</p></body></htm>",
}) catch "<html><head><meta charset=\"utf-8\"></head><body><h1>Navigation failed</h1></body></htm>";
var parser = Parser.init(parse_arena, self.document.asNode(), self);
parser.parse(html);
self.documentIsComplete();
},
else => unreachable,
}
}
@@ -797,25 +812,14 @@ fn pageErrorCallback(ctx: *anyopaque, err: anyerror) void {
log.err(.page, "navigate failed", .{ .err = err });
var self: *Page = @ptrCast(@alignCast(ctx));
self.clearTransferArena();
self._parse_state = .{ .err = err };
defer self.documentIsComplete();
// Generate a pseudo HTML page indicating the navigation falilure.
const parse_arena = self.getArena(.{ .debug = "Page.parse" }) catch |e| {
log.err(.browser, "get arena on pageErrorCallback", .{ .err = e });
// In case of error, we want to complete the page with a custom HTML
// containing the error.
pageDoneCallback(ctx) catch |e| {
log.err(.browser, "pageErrorCallback", .{ .err = e });
return;
};
defer self.releaseArena(parse_arena);
const html = std.mem.concat(parse_arena, u8, &.{
"<html><head><meta charset=\"utf-8\"></head><body><h1>Navigation failed</h1><p>Reason: ",
@errorName(err),
"</p></body></htm>",
}) catch "<html><head><meta charset=\"utf-8\"></head><body><h1>Navigation failed</h1></body></htm>";
var parser = Parser.init(parse_arena, self.document.asNode(), self);
parser.parse(html);
}
// The transfer arena is useful and interesting, but has a weird lifetime.