public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Fix partitionKey ignore PR

Browse Source 
Fixes https://github.com/lightpanda-io/browser/pull/1821 so that it compiles
This commit is contained in:
Karl Seguin
2026-03-16 07:28:14 +08:00
parent 68337a6989
commit 1ec3e156fb
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cdp/domains/network.zig
View File

@@ -122,7 +122,7 @@ fn deleteCookies(cmd: anytype) !void {
// This allows Puppeteer's page.setCookie() to work, which sends deleteCookies // This allows Puppeteer's page.setCookie() to work, which sends deleteCookies
// with partitionKey as part of its cookie-setting workflow. // with partitionKey as part of its cookie-setting workflow.
if (params.partitionKey != null) { if (params.partitionKey != null) {
log.debug(.network, "partitionKey ignored in deleteCookies", .{}); log.warn(.not_implemented, "partition key", .{.src = "deleteCookies"});
} }
const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded; const bc = cmd.browser_context orelse return error.BrowserContextNotLoaded;

2
src/cdp/domains/storage.zig
View File

@@ -132,7 +132,7 @@ pub fn setCdpCookie(cookie_jar: *CookieJar, param: CdpCookie) !void {
// This allows Puppeteer's page.setCookie() to work, which may send cookies with // This allows Puppeteer's page.setCookie() to work, which may send cookies with
// partitionKey as part of its cookie-setting workflow. // partitionKey as part of its cookie-setting workflow.
if (param.partitionKey != null) { if (param.partitionKey != null) {
log.debug(.storage, "partitionKey ignored in setCdpCookie", .{}); log.warn(.not_implemented, "partition key", .{.src = "setCdpCookie"});
} }
// Still reject unsupported features // Still reject unsupported features
if (param.priority != .Medium or param.sameParty != null or param.sourceScheme != null) { if (param.priority != .Medium or param.sameParty != null or param.sourceScheme != null) {