public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 07:03:29 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

characterdata: add nextElementSibling getter

Browse Source 
Signed-off-by: Francis Bouvier <francis.bouvier@gmail.com>
This commit is contained in:
Francis Bouvier
2023-10-02 17:25:32 +02:00
parent 2d6f497946
commit 202ee1646d
2 changed files with 44 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/dom/character_data.zig
View File

@@ -10,6 +10,7 @@ const parser = @import("../netsurf.zig");
const Node = @import("node.zig").Node;
const Comment = @import("comment.zig").Comment;
const Text = @import("text.zig").Text;
const HTMLElem = @import("../html/elements.zig");
pub const CharacterData = struct {
pub const Self = parser.CharacterData;
@@ -25,6 +26,14 @@ pub const CharacterData = struct {
return parser.characterDataLength(self);
}
pub fn get_nextElementSibling(self: *parser.CharacterData) ?HTMLElem.Union {
const res = parser.nodeNextElementSibling(parser.characterDataToNode(self));
if (res == null) {
return null;
}
return HTMLElem.toInterface(HTMLElem.Union, res.?);
}
// Read/Write attributes
pub fn get_data(self: *parser.CharacterData) []const u8 {
@@ -53,20 +62,30 @@ pub fn testExecFn(
comptime _: []jsruntime.API,
) !void {
var get_data = [_]Case{
.{ .src = "let cdata_t = document.getElementById('link').firstChild", .ex = "undefined" },
.{ .src = "cdata_t.data", .ex = "OK" },
.{ .src = "let link = document.getElementById('link')", .ex = "undefined" },
.{ .src = "let cdata = link.firstChild", .ex = "undefined" },
.{ .src = "cdata.data", .ex = "OK" },
};
try checkCases(js_env, &get_data);
var set_data = [_]Case{
.{ .src = "cdata_t.data = 'OK modified'", .ex = "OK modified" },
.{ .src = "cdata_t.data === 'OK modified'", .ex = "true" },
.{ .src = "cdata_t.data = 'OK'", .ex = "OK" },
.{ .src = "cdata.data = 'OK modified'", .ex = "OK modified" },
.{ .src = "cdata.data === 'OK modified'", .ex = "true" },
.{ .src = "cdata.data = 'OK'", .ex = "OK" },
};
try checkCases(js_env, &set_data);
var get_length = [_]Case{
.{ .src = "cdata_t.length === 2", .ex = "true" },
.{ .src = "cdata.length === 2", .ex = "true" },
};
try checkCases(js_env, &get_length);
var get_next_elem_sibling = [_]Case{
.{ .src = "cdata.nextElementSibling === null", .ex = "true" },
// create a next element
.{ .src = "let next = document.createElement('a')", .ex = "undefined" },
.{ .src = "link.appendChild(next, cdata) !== undefined", .ex = "true" },
.{ .src = "cdata.nextElementSibling.localName === 'a' ", .ex = "true" },
};
try checkCases(js_env, &get_next_elem_sibling);
}

19
src/netsurf.zig
View File

@@ -267,6 +267,21 @@ pub fn nodeNextSibling(node: *Node) ?*Node {
return res;
}
pub fn nodeNextElementSibling(node: *Node) ?*Element {
var n = node;
while (true) {
const next = nodeNextSibling(n);
if (next == null) {
return null;
}
if (nodeType(next.?) == .element) {
return @as(*Element, @ptrCast(next.?));
}
n = next.?;
}
return null;
}
pub fn nodePreviousSibling(node: *Node) ?*Node {
var res: ?*Node = undefined;
_ = nodeVtable(node).dom_node_get_previous_sibling.?(node, &res);
@@ -424,6 +439,10 @@ fn characterDataVtable(data: *CharacterData) c.dom_characterdata_vtable {
return getVtable(c.dom_characterdata_vtable, CharacterData, data);
}
pub inline fn characterDataToNode(cdata: *CharacterData) *Node {
return @as(*Node, @ptrCast(cdata));
}
pub fn characterDataData(cdata: *CharacterData) []const u8 {
var s: ?*String = undefined;
_ = characterDataVtable(cdata).dom_characterdata_get_data.?(cdata, &s);