public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 23:23:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

setChildNodes checks

Browse Source
This commit is contained in:
sjorsdonkers
2025-05-21 10:11:54 +02:00
committed by Sjors
parent 4322d8e494
commit 2cdfc3f4c3
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/cdp/domains/dom.zig
View File

@@ -230,10 +230,9 @@ fn querySelectorAll(cmd: anytype) !void {
const node = bc.node_registry.lookup_by_id.get(params.nodeId) orelse return error.UnknownNode; const node = bc.node_registry.lookup_by_id.get(params.nodeId) orelse return error.UnknownNode;
const arena = cmd.arena; const arena = cmd.arena;
var selected_nodes = try css.querySelectorAll(arena, node._node, params.selector); const selected_nodes = try css.querySelectorAll(arena, node._node, params.selector);
defer selected_nodes.deinit(arena);
const nodes = selected_nodes.nodes.items; const nodes = selected_nodes.nodes.items;
const node_ids = try arena.alloc(Node.Id, nodes.len); const node_ids = try arena.alloc(Node.Id, nodes.len);
for (nodes, node_ids) |selected_node, *node_id| { for (nodes, node_ids) |selected_node, *node_id| {
node_id.* = (try bc.node_registry.register(selected_node)).id; node_id.* = (try bc.node_registry.register(selected_node)).id;
@@ -522,7 +521,7 @@ test "cdp.dom: querySelector Nodes found" {
.method = "DOM.querySelector", .method = "DOM.querySelector",
.params = .{ .nodeId = 0, .selector = "p" }, .params = .{ .nodeId = 0, .selector = "p" },
}); });
// TODO Check 1 or more "DOM.setChildNodes" was send try ctx.expectSentEvent("DOM.setChildNodes", null, .{});
try ctx.expectSentResult(.{ .nodeId = 5 }, .{ .id = 4 }); try ctx.expectSentResult(.{ .nodeId = 5 }, .{ .id = 4 });
try ctx.processMessage(.{ try ctx.processMessage(.{
@@ -530,6 +529,6 @@ test "cdp.dom: querySelector Nodes found" {
.method = "DOM.querySelectorAll", .method = "DOM.querySelectorAll",
.params = .{ .nodeId = 0, .selector = "p" }, .params = .{ .nodeId = 0, .selector = "p" },
}); });
// TODO Check 1 or more "DOM.setChildNodes" was send try ctx.expectSentEvent("DOM.setChildNodes", null, .{});
try ctx.expectSentResult(.{ .nodeIds = &.{5} }, .{ .id = 5 }); try ctx.expectSentResult(.{ .nodeIds = &.{5} }, .{ .id = 5 });
} }