public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-30 15:41:48 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

No need to navigate to about:blank

Browse Source
This commit is contained in:
sjorsdonkers
2025-05-20 12:39:46 +02:00
committed by Sjors
parent 967ab18d53
commit 3f31573bcb
3 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/cdp/domains/target.zig
View File

@@ -125,9 +125,6 @@ fn createTarget(cmd: anytype) !void {
bc.target_id = target_id;
var page = try bc.session.createPage();
// Navigate to about:blank such that the window.document are created and set
const url = @import("../../url.zig").URL.about_blank;
try page.navigate(url, .{});
{
const aux_data = try std.fmt.allocPrint(cmd.arena, "{{\"isDefault\":true,\"type\":\"default\",\"frameId\":\"{s}\"}}", .{target_id});
bc.inspector.contextCreated(
@@ -504,10 +501,6 @@ test "cdp.target: createTarget" {
// should create a browser context
const bc = ctx.cdp().browser_context.?;
try ctx.expectSentEvent("Target.targetCreated", .{ .targetInfo = .{ .url = "about:blank", .title = "about:blank", .attached = false, .type = "page", .canAccessOpener = false, .browserContextId = bc.id, .targetId = bc.target_id.? } }, .{});
// Even about:blank should set the window.document
const page = ctx.cdp().browser_context.?.session.page.?;
try testing.expect(page.window.document != null);
}
{