public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-28 15:40:04 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

refactor: simplify form extraction and remove const casts

Browse Source
This commit is contained in:
Adrià Arrufat
2026-03-23 13:24:21 +09:00
parent a6d2ec7610
commit 4b29823a5b
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/browser/forms.zig
View File

@@ -48,7 +48,7 @@ pub const FormField = struct {
required: bool, required: bool,
value: ?[]const u8, value: ?[]const u8,
placeholder: ?[]const u8, placeholder: ?[]const u8,
options: []const SelectOption, options: []SelectOption,
pub fn jsonStringify(self: *const FormField, jw: anytype) !void { pub fn jsonStringify(self: *const FormField, jw: anytype) !void {
try jw.beginObject(); try jw.beginObject();
@@ -104,7 +104,7 @@ pub const FormInfo = struct {
node: *Node, node: *Node,
action: ?[]const u8, action: ?[]const u8,
method: ?[]const u8, method: ?[]const u8,
fields: []const FormField, fields: []FormField,
pub fn jsonStringify(self: *const FormInfo, jw: anytype) !void { pub fn jsonStringify(self: *const FormInfo, jw: anytype) !void {
try jw.beginObject(); try jw.beginObject();
@@ -159,7 +159,7 @@ pub fn collectForms(
try forms.append(arena, .{ try forms.append(arena, .{
.node = node, .node = node,
.action = if (action_attr) |a| if (a.len > 0) a else null else null, .action = if (action_attr) |a| if (a.len > 0) a else null else null,
.method = if (method_str.len > 0) method_str else null, .method = method_str,
.fields = fields, .fields = fields,
}); });
} }

2
src/cdp/domains/lp.zig
View File

@@ -176,7 +176,7 @@ fn detectForms(cmd: anytype) !void {
for (forms_data) |*form| { for (forms_data) |*form| {
const registered = try bc.node_registry.register(form.node); const registered = try bc.node_registry.register(form.node);
form.backendNodeId = registered.id; form.backendNodeId = registered.id;
for (@constCast(form.fields)) |*field| { for (form.fields) |*field| {
const field_registered = try bc.node_registry.register(field.node); const field_registered = try bc.node_registry.register(field.node);
field.backendNodeId = field_registered.id; field.backendNodeId = field_registered.id;
} }

2
src/mcp/tools.zig
View File

@@ -475,7 +475,7 @@ fn handleDetectForms(server: *Server, arena: std.mem.Allocator, id: std.json.Val
const form_registered = try server.node_registry.register(form.node); const form_registered = try server.node_registry.register(form.node);
form.backendNodeId = form_registered.id; form.backendNodeId = form_registered.id;
for (@constCast(form.fields)) |*field| { for (form.fields) |*field| {
const field_registered = try server.node_registry.register(field.node); const field_registered = try server.node_registry.register(field.node);
field.backendNodeId = field_registered.id; field.backendNodeId = field_registered.id;
} }