use fetch logging scope, clean some comments

This commit is contained in:
Muki Kiboigo
2025-09-16 12:41:35 -07:00
parent 3badcdbdbd
commit 4d1e416299
2 changed files with 7 additions and 8 deletions

View File

@@ -85,15 +85,11 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
const arena = page.arena;
const req = try Request.constructor(input, options, page);
const resolver = page.main_context.createPersistentPromiseResolver();
var headers = try Http.Headers.init();
// Copy our headers into the HTTP headers.
var header_iter = req.headers.headers.iterator();
while (header_iter.next()) |entry| {
// This is fine because curl/headers copies it internally.
const combined = try std.fmt.allocPrintSentinel(
page.arena,
"{s}: {s}",
@@ -105,6 +101,8 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
try page.requestCookie(.{}).headersForRequest(arena, req.url, &headers);
const resolver = page.main_context.createPersistentPromiseResolver();
const fetch_ctx = try arena.create(FetchContext);
fetch_ctx.* = .{
.arena = arena,
@@ -126,7 +124,7 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
.start_callback = struct {
fn startCallback(transfer: *HttpClient.Transfer) !void {
const self: *FetchContext = @ptrCast(@alignCast(transfer.ctx));
log.debug(.http, "request start", .{ .method = self.method, .url = self.url, .source = "fetch" });
log.debug(.fetch, "request start", .{ .method = self.method, .url = self.url, .source = "fetch" });
self.transfer = transfer;
}
@@ -137,7 +135,7 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
const header = &transfer.response_header.?;
log.debug(.http, "request header", .{
log.debug(.fetch, "request header", .{
.source = "fetch",
.method = self.method,
.url = self.url,
@@ -175,7 +173,7 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
defer self.promise_resolver.deinit();
self.transfer = null;
log.info(.http, "request complete", .{
log.info(.fetch, "request complete", .{
.source = "fetch",
.method = self.method,
.url = self.url,
@@ -192,7 +190,7 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
defer self.promise_resolver.deinit();
self.transfer = null;
log.err(.http, "error", .{
log.err(.fetch, "error", .{
.url = self.url,
.err = err,
.source = "fetch error",

View File

@@ -39,6 +39,7 @@ pub const Scope = enum {
unknown_prop,
web_api,
xhr,
fetch,
polyfill,
mouse_event,
};