public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-21 20:24:42 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1504 from lightpanda-io/selection_fix_2

Browse Source 
WPT Selection fixes
This commit is contained in:
Karl Seguin
2026-02-09 22:27:38 +08:00
committed by GitHub
parent 6ce136bede e6fb63ddba
commit 5904d72776
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/browser/webapi/Selection.zig
View File

@@ -110,8 +110,15 @@ pub fn getType(self: *const Selection) []const u8 {
return "Range";
}
pub fn addRange(self: *Selection, range: *Range) !void {
pub fn addRange(self: *Selection, range: *Range, page: *Page) !void {
if (self._range != null) return;
// Only add the range if its root node is in the document associated with this selection
const start_node = range.asAbstractRange().getStartContainer();
if (!page.document.asNode().contains(start_node)) {
return;
}
self._range = range;
}
@@ -145,7 +152,7 @@ pub fn collapseToEnd(self: *Selection, page: *Page) !void {
}
pub fn collapseToStart(self: *Selection, page: *Page) !void {
const range = self._range orelse return;
const range = self._range orelse return error.InvalidStateError;
const abstract = range.asAbstractRange();
const first_node = abstract.getStartContainer();
@@ -409,7 +416,7 @@ pub const JsApi = struct {
pub const addRange = bridge.function(Selection.addRange, .{});
pub const collapse = bridge.function(Selection.collapse, .{ .dom_exception = true });
pub const collapseToEnd = bridge.function(Selection.collapseToEnd, .{});
pub const collapseToStart = bridge.function(Selection.collapseToStart, .{});
pub const collapseToStart = bridge.function(Selection.collapseToStart, .{ .dom_exception = true });
pub const containsNode = bridge.function(Selection.containsNode, .{});
pub const deleteFromDocument = bridge.function(Selection.deleteFromDocument, .{});
pub const empty = bridge.function(Selection.removeAllRanges, .{});