public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-22 04:34:44 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1880 from lightpanda-io/logfilter-init-slice
Some checks failed
zig-test / zig test using v8 in debug mode (push) Has been cancelled
Details
zig-test / zig test (push) Has been cancelled
Details
zig-test / perf-fmt (push) Has been cancelled
Details

Browse Source 
LogFilter: init with slice and silence tests
This commit is contained in:
Karl Seguin
2026-03-17 17:42:23 +08:00
committed by GitHub
parent 5b1056862a b698e2d078
commit 7009fb5899
4 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/browser/Page.zig
View File

@@ -3523,13 +3523,16 @@ fn asUint(comptime string: anytype) std.meta.Int(
const testing = @import("../testing.zig");
test "WebApi: Page" {
const filter: testing.LogFilter = .init(.http);
const filter: testing.LogFilter = .init(&.{ .http, .js });
defer filter.deinit();
try testing.htmlRunner("page", .{});
}
test "WebApi: Frames" {
const filter: testing.LogFilter = .init(&.{.js});
defer filter.deinit();
try testing.htmlRunner("frames", .{});
}

2
src/cdp/domains/page.zig
View File

@@ -663,7 +663,7 @@ test "cdp.page: getFrameTree" {
test "cdp.page: captureScreenshot" {
const LogFilter = @import("../../testing.zig").LogFilter;
const filter: LogFilter = .init(.not_implemented);
const filter: LogFilter = .init(&.{.not_implemented});
defer filter.deinit();
var ctx = testing.context();

2
src/mcp/router.zig
View File

@@ -148,7 +148,7 @@ test "MCP.router - handleMessage - synchronous unit tests" {
// 5. Parse error
{
const filter: testing.LogFilter = .init(.mcp);
const filter: testing.LogFilter = .init(&.{.mcp});
defer filter.deinit();
try handleMessage(server, aa, "invalid json");

8
src/testing.zig
View File

@@ -616,12 +616,12 @@ fn testHTTPHandler(req: *std.http.Server.Request) !void {
pub const LogFilter = struct {
old_filter: []const log.Scope,
/// Sets the log filter to only include the specified scope.
/// Sets the log filter to suppress the specified scope(s).
/// Returns a LogFilter that should be deinitialized to restore previous filters.
pub fn init(comptime scope: log.Scope) LogFilter {
pub fn init(comptime scopes: []const log.Scope) LogFilter {
comptime std.debug.assert(@TypeOf(scopes) == []const log.Scope);
const old_filter = log.opts.filter_scopes;
const new_filter = comptime &[_]log.Scope{scope};
log.opts.filter_scopes = new_filter;
log.opts.filter_scopes = scopes;
return .{ .old_filter = old_filter };
}