mirror of
https://github.com/lightpanda-io/browser.git
synced 2026-03-22 04:34:44 +00:00
address review: fix doc comment, skip buffered if already queued
This commit is contained in:
@@ -1246,7 +1246,7 @@ pub fn notifyPerformanceObservers(self: *Page, entry: *Performance.Entry) !void
|
||||
try self.schedulePerformanceObserverDelivery();
|
||||
}
|
||||
|
||||
/// Schedules async delivery of buffered performance observer records.
|
||||
/// Schedules async delivery of performance observer records.
|
||||
pub fn schedulePerformanceObserverDelivery(self: *Page) !void {
|
||||
// Already scheduled.
|
||||
if (self._performance_delivery_scheduled) {
|
||||
|
||||
@@ -117,7 +117,7 @@ pub fn observe(
|
||||
// Deliver existing entries if buffered option is set.
|
||||
// Per spec, buffered is only valid with the type option, not entryTypes.
|
||||
// Delivery is async via a queued task, not synchronous.
|
||||
if (options.buffered and options.type != null) {
|
||||
if (options.buffered and options.type != null and !self.hasRecords()) {
|
||||
for (page.window._performance._entries.items) |entry| {
|
||||
if (self.interested(entry)) {
|
||||
try self._entries.append(page.arena, entry);
|
||||
|
||||
Reference in New Issue
Block a user