address review: fix doc comment, skip buffered if already queued

This commit is contained in:
egrs
2026-02-18 07:14:12 +01:00
parent ca9e2200da
commit 7c92e0e9ce
2 changed files with 2 additions and 2 deletions

View File

@@ -1246,7 +1246,7 @@ pub fn notifyPerformanceObservers(self: *Page, entry: *Performance.Entry) !void
try self.schedulePerformanceObserverDelivery(); try self.schedulePerformanceObserverDelivery();
} }
/// Schedules async delivery of buffered performance observer records. /// Schedules async delivery of performance observer records.
pub fn schedulePerformanceObserverDelivery(self: *Page) !void { pub fn schedulePerformanceObserverDelivery(self: *Page) !void {
// Already scheduled. // Already scheduled.
if (self._performance_delivery_scheduled) { if (self._performance_delivery_scheduled) {

View File

@@ -117,7 +117,7 @@ pub fn observe(
// Deliver existing entries if buffered option is set. // Deliver existing entries if buffered option is set.
// Per spec, buffered is only valid with the type option, not entryTypes. // Per spec, buffered is only valid with the type option, not entryTypes.
// Delivery is async via a queued task, not synchronous. // Delivery is async via a queued task, not synchronous.
if (options.buffered and options.type != null) { if (options.buffered and options.type != null and !self.hasRecords()) {
for (page.window._performance._entries.items) |entry| { for (page.window._performance._entries.items) |entry| {
if (self.interested(entry)) { if (self.interested(entry)) {
try self._entries.append(page.arena, entry); try self._entries.append(page.arena, entry);