public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-28 14:43:28 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

try setting to weak instead of deinit

Browse Source
This commit is contained in:
Muki Kiboigo
2025-09-17 06:39:27 -07:00
parent 4d1e416299
commit 7d96a25c55
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/browser/fetch/fetch.zig
View File

@@ -170,7 +170,7 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
.done_callback = struct { .done_callback = struct {
fn doneCallback(ctx: *anyopaque) !void { fn doneCallback(ctx: *anyopaque) !void {
const self: *FetchContext = @ptrCast(@alignCast(ctx)); const self: *FetchContext = @ptrCast(@alignCast(ctx));
defer self.promise_resolver.deinit(); defer self.promise_resolver.setWeak();
self.transfer = null; self.transfer = null;
log.info(.fetch, "request complete", .{ log.info(.fetch, "request complete", .{
@@ -187,7 +187,7 @@ pub fn fetch(input: RequestInput, options: ?RequestInit, page: *Page) !Env.Promi
.error_callback = struct { .error_callback = struct {
fn errorCallback(ctx: *anyopaque, err: anyerror) void { fn errorCallback(ctx: *anyopaque, err: anyerror) void {
const self: *FetchContext = @ptrCast(@alignCast(ctx)); const self: *FetchContext = @ptrCast(@alignCast(ctx));
defer self.promise_resolver.deinit(); defer self.promise_resolver.setWeak();
self.transfer = null; self.transfer = null;
log.err(.fetch, "error", .{ log.err(.fetch, "error", .{

4
src/runtime/js.zig
View File

@@ -2246,6 +2246,10 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
self.resolver.deinit(); self.resolver.deinit();
} }
pub fn setWeak(self: *PersistentPromiseResolver) void {
self.resolver.setWeak();
}
pub fn promise(self: PersistentPromiseResolver) Promise { pub fn promise(self: PersistentPromiseResolver) Promise {
return .{ return .{
.promise = self.resolver.castToPromiseResolver().getPromise(), .promise = self.resolver.castToPromiseResolver().getPromise(),