public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2026-03-21 20:24:42 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Merge pull request #1678 from lightpanda-io/improve_atob

Browse Source 
Re-implement forgiving base64 decode without intermediate allocation
This commit is contained in:
Karl Seguin
2026-02-28 14:45:01 +08:00
committed by GitHub
parent 8997df861a 7fc6e97cd8
commit 8b99e82743
1 changed files with 11 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/browser/webapi/Window.zig
View File

@@ -396,28 +396,19 @@ pub fn btoa(_: *const Window, input: []const u8, page: *Page) ![]const u8 {
pub fn atob(_: *const Window, input: []const u8, page: *Page) ![]const u8 {
const trimmed = std.mem.trim(u8, input, &std.ascii.whitespace);
// Per HTML spec "forgiving-base64 decode" algorithm:
// Forgiving base64 decode per WHATWG spec:
// https://infra.spec.whatwg.org/#forgiving-base64-decode
const padded: []const u8 = switch (trimmed.len % 4) {
1 => return error.InvalidCharacterError,
2 => blk: {
const buf = try page.call_arena.alloc(u8, trimmed.len + 2);
@memcpy(buf[0..trimmed.len], trimmed);
buf[trimmed.len] = '=';
buf[trimmed.len + 1] = '=';
break :blk buf;
},
3 => blk: {
const buf = try page.call_arena.alloc(u8, trimmed.len + 1);
@memcpy(buf[0..trimmed.len], trimmed);
buf[trimmed.len] = '=';
break :blk buf;
},
else => trimmed,
};
const decoded_len = std.base64.standard.Decoder.calcSizeForSlice(padded) catch return error.InvalidCharacterError;
// Remove trailing padding to use standard_no_pad decoder
const unpadded = std.mem.trimRight(u8, trimmed, "=");
// Length % 4 == 1 is invalid (can't represent valid base64)
if (unpadded.len % 4 == 1) {
return error.InvalidCharacterError;
}
const decoded_len = std.base64.standard_no_pad.Decoder.calcSizeForSlice(unpadded) catch return error.InvalidCharacterError;
const decoded = try page.call_arena.alloc(u8, decoded_len);
std.base64.standard.Decoder.decode(decoded, padded) catch return error.InvalidCharacterError;
std.base64.standard_no_pad.Decoder.decode(decoded, unpadded) catch return error.InvalidCharacterError;
return decoded;
}