public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-28 14:43:28 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #389 from lightpanda-io/cdp-empty-params
Some checks failed
wpt / web platform tests (push) Has been cancelled
Details
zig-test / zig build dev (push) Has been cancelled
Details
zig-test / zig build release (push) Has been cancelled
Details
zig-test / zig test (push) Has been cancelled
Details
wpt / perf-fmt (push) Has been cancelled
Details
zig-test / perf-fmt (push) Has been cancelled
Details
zig-test / demo-puppeteer (push) Has been cancelled
Details

Browse Source 
chromedp: msg missing params or result
This commit is contained in:
Pierre Tachoire
2025-01-28 17:11:03 +01:00
committed by GitHub
parent 3fb16774b7 8aac26a331
commit a74c9e8481
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/cdp/cdp.zig
View File

@@ -206,6 +206,9 @@ pub fn sendEvent(
params: T,
sessionID: ?[]const u8,
) !void {
// some clients like chromedp expects empty parameters structs.
if (T == void) @compileError("sendEvent: use struct{} instead of void for empty parameters");
log_cdp.debug("Event > method {s}, sessionID {?s}", .{ name, sessionID });
const Resp = struct {
method: []const u8,

2
src/cdp/page.zig
View File

@@ -329,7 +329,7 @@ fn navigate(
// Send Runtime.executionContextsCleared event
// TODO: noop event, we have no env context at this point, is it necesarry?
try sendEvent(alloc, ctx, "Runtime.executionContextsCleared", void, {}, input.sessionId);
try sendEvent(alloc, ctx, "Runtime.executionContextsCleared", struct {}, .{}, input.sessionId);
// Launch navigate, the page must have been created by a
// target.createTarget.