public/browser
1
0
Fork 0
mirror of https://github.com/lightpanda-io/browser.git synced 2025-10-29 15:13:28 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

browser: update window injection TODO

Browse Source
This commit is contained in:
Pierre Tachoire
2023-12-21 11:35:43 +01:00
parent 0d32fc62ba
commit bd9c63f22f
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/browser/browser.zig
View File

@@ -143,9 +143,17 @@ pub const Page = struct {
// add global objects
log.debug("setup global env", .{});
const window = Window.create(doc, null);
// TODO should'nt we share the same pointer between instances of window?
try self.env.addObject(apis, window, "self");
// TODO we must share the same pointer between window and self.
// once https://github.com/lightpanda-io/jsruntime-lib/issues/171 is
// done, replace the 2 lines with:
//
// const obj = try js_env.addObject(apis, window, "window");
// try js_env.attachObject(try js_env.getGlobal(), "self", obj);
//
try self.env.addObject(apis, window, "window");
try self.env.addObject(apis, window, "self");
try self.env.addObject(apis, doc, "document");
}
};